Move VS Code integration tests to /test directory#1912
Merged
Conversation
charisk
force-pushed
the
charisk/move-vscode-tests
branch
3 times, most recently
from
39aef31 to
77e7ed1
Compare
norascheuch
reviewed
Jan 3, 2023
norascheuch
reviewed
Jan 3, 2023
| "resolveJsonModule": true, | ||
| "rootDir": ".." | ||
| "rootDir": "..", | ||
| "jsx": "react" |
Contributor
There was a problem hiding this comment.
Why did you add this here?
Contributor
Author
There was a problem hiding this comment.
Because we now need to compile jsx files as part of /test (because we compile all of /extensions/ql-vscode which includes /src)
norascheuch
approved these changes
Jan 3, 2023
Contributor
norascheuch
left a comment
norascheuch
left a comment
There was a problem hiding this comment.
✨ 😮 Amazing changes!
charisk
force-pushed
the
charisk/move-vscode-tests
branch
from
77e7ed1 to
dfc85f0
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves VS Code integration tests out of
/srcand into/test.Checklist
N/A:
ready-for-doc-reviewlabel there.